Skip site navigation (1) Skip section navigation (2)

Re: pgsql: pg_bind_textdomain_codeset must exist only on ENABLE_NLS.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: pg_bind_textdomain_codeset must exist only on ENABLE_NLS.
Date: 2009-03-08 20:11:52
Message-ID: 1936.1236543112@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
alvherre(at)postgresql(dot)org (Alvaro Herrera) writes:
> pg_bind_textdomain_codeset must exist only on ENABLE_NLS.

I think the previous coding, where it was defined but empty without
ENABLE_NLS, was better.  As-is, you've introduced an unnecessary reason
for NLS-compiled loadable modules to fail to work with non-NLS core
backends.

			regards, tom lane

In response to

Responses

pgsql-committers by date

Next:From: Alvaro HerreraDate: 2009-03-09 00:01:32
Subject: pgsql: Revert pg_bind_textdomain_codeset to a existant-but-empty
Previous:From: Magnus HaganderDate: 2009-03-08 19:14:44
Subject: Re: Re: [COMMITTERS] pgsql: Avoid MSVC breakage caused by my previous commit by not using a

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group