Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> ScanState.ss_currentScanDesc is currently used by only SeqScan and
> BitmapHeapScan. Other scan nodes don't use the field at all, right?
> Can we move the field into SeqScanState and BitmapHeapScanState
> for code cleanup? This change will not improve any performance,
> but it can clear up what we do actually.
Why is that an improvement? ISTM that the fact that other scan types
don't use a scandesc pointer is the oddity, not that these do. You'd
also be making it harder to share any code between these two cases.
regards, tom lane
In response to
pgsql-hackers by date
|Next:||From: Gokulakannan Somasundaram||Date: 2010-02-26 06:09:10|
|Subject: Re: A thought on Index Organized Tables|
|Previous:||From: Дмитрий Фефелов||Date: 2010-02-26 05:55:06|
|Subject: Re: Alpha4 Available Now|