Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Formatting patch for psql

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Martijn van Oosterhout <kleptog(at)svana(dot)org>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCH] Formatting patch for psql
Date: 2005-11-25 02:23:55
Message-ID: 17281.1132885435@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> And what I'm saying is that you can only do that if all single byte
> encodings are ASCII compatable and I'm not prepared to say that...

psql already assumes that; see the flex processor.

> So in the switch statement I listed the encodings I know to be ASCII
> compatable and at some point someone who actually knows the other
> encodings will explain what needs to be done.

Even if this were an appropriate solution, the formatting code is not
the place to put such knowledge...

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Martijn van OosterhoutDate: 2005-11-25 10:42:26
Subject: Re: [PATCH] Formatting patch for psql
Previous:From: Martijn van OosterhoutDate: 2005-11-24 22:57:07
Subject: Re: [PATCH] Formatting patch for psql

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group