Skip site navigation (1) Skip section navigation (2)

Re: plpgsql: open for execute - add USING clause

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: plpgsql: open for execute - add USING clause
Date: 2010-01-13 08:05:35
Message-ID: 162867791001130005l34e5e686l9b1d3a7984765a9d@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
2010/1/12 Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>:
> Hi, I'm reviewing OPEN FOR EXECUTE USING patch and have a couple of
> trivial comments.
>
> Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>
>> this small patch add missing USING clause to OPEN FOR EXECUTE statement
>> + cleaning part of exec_stmt_open function
>
> - Can we use read_sql_expression2() instead of read_sql_construct()
>  in gram.y? It could simplify the code a bit.
>
> - I'd prefer to change the new argument for exec_dynquery_with_params()
>  from "char *portalname" to "const char *curname".
>

ok, I accept all comments.

revised version are attached.

Thank you,

Pavel Stehule

> Other than the above minor issues, this patch is ready to commit.
>
> Regards,
> ---
> Takahiro Itagaki
> NTT Open Source Software Center
>
>
>

Attachment: openexecusing-after-rev.diff
Description: application/octet-stream (11.2 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Boszormenyi ZoltanDate: 2010-01-13 08:22:28
Subject: Re: ECPG patch causes warning
Previous:From: Michael MeskesDate: 2010-01-13 07:51:43
Subject: Re: ECPG patch causes warning

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group