Skip site navigation (1)
Skip section navigation (2)
Peripheral Links
Re: plpgsql: open for execute - add USING clause
2010/1/12 Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>: > Hi, I'm reviewing OPEN FOR EXECUTE USING patch and have a couple of > trivial comments. > > Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote: > >> this small patch add missing USING clause to OPEN FOR EXECUTE statement >> + cleaning part of exec_stmt_open function > > - Can we use read_sql_expression2() instead of read_sql_construct() > in gram.y? It could simplify the code a bit. > > - I'd prefer to change the new argument for exec_dynquery_with_params() > from "char *portalname" to "const char *curname". > ok, I accept all comments. revised version are attached. Thank you, Pavel Stehule > Other than the above minor issues, this patch is ready to commit. > > Regards, > --- > Takahiro Itagaki > NTT Open Source Software Center > > >
Attachment: openexecusing-after-rev.diff
Description: application/octet-stream (11.2 KB)
Description: application/octet-stream (11.2 KB)
In response to
- Re: plpgsql: open for execute - add USING clause at 2010-01-12 09:38:00 from Takahiro Itagaki
Responses
- Re: plpgsql: open for execute - add USING clause at 2010-01-14 01:34:21 from Takahiro Itagaki
- Re: plpgsql: open for execute - add USING clause at 2010-01-19 01:37:17 from Tom Lane
pgsql-hackers by date
Next: From: Boszormenyi Zoltan Date: 2010-01-13 08:22:28 Subject: Re: ECPG patch causes warning Previous: From: Michael Meskes Date: 2010-01-13 07:51:43 Subject: Re: ECPG patch causes warning