Skip site navigation (1) Skip section navigation (2)

Re: vacuum as flags in PGPROC

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: vacuum as flags in PGPROC
Date: 2007-10-24 22:00:15
Message-ID: 15765.1193263215@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Also, I forgot to mention it on the first email, but this patch adds
> errcontext() lines when an autovacuum/analyze is being aborted.  It
> works fine, but I'm not seeing code anywhere else that does something
> like this.

This is a little bit scary because you might be invoking system catalog
reads after the transaction has already failed.  What would it take to
save the names involved before starting the TRY block?  I'm not worried
about the errcontext() call per se, only about the syscache fetches.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Joe ConwayDate: 2007-10-25 02:26:16
Subject: Re: Crosstab Problems
Previous:From: Bruce MomjianDate: 2007-10-24 17:01:32
Subject: Re: [HACKERS] Including Snapshot Info with Indexes

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group