Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Remove too-smart-for-its-own-good optimization of not overwriting

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Remove too-smart-for-its-own-good optimization of not overwriting
Date: 2010-01-05 03:51:34
Message-ID: 15130.1262663494@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Jan 4, 2010 at 9:34 PM, Tom Lane <tgl(at)postgresql(dot)org> wrote:
>> Log Message:
>> -----------
>> Remove too-smart-for-its-own-good optimization of not overwriting the output
>> files when they haven't changed. This confuses make because the build fails
>> to update the file timestamps, and so it keeps on doing the action over again.

> This doesn't seem like a good idea.

The original code was a bad idea, written by someone who was a
self-acknowledged non expert on make.  The way that you avoid
unnecessary recompilations is by not changing the input files,
not by breaking the file timestamp relationships that make depends
on to work sanely.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Greg StarkDate: 2010-01-05 03:53:07
Subject: Re: [COMMITTERS] pgsql: Remove too-smart-for-its-own-good optimization of not overwriting
Previous:From: Robert HaasDate: 2010-01-05 03:51:10
Subject: Re: Verifying variable names in pgbench

pgsql-committers by date

Next:From: Greg StarkDate: 2010-01-05 03:53:07
Subject: Re: [COMMITTERS] pgsql: Remove too-smart-for-its-own-good optimization of not overwriting
Previous:From: Robert HaasDate: 2010-01-05 03:42:30
Subject: Re: [COMMITTERS] pgsql: Remove too-smart-for-its-own-good optimization of not overwriting

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group