Skip site navigation (1) Skip section navigation (2)

Re: several problems in pg_receivexlog

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: several problems in pg_receivexlog
Date: 2012-07-31 15:09:02
Message-ID: 1343747204-sup-3005@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackers
Excerpts from Fujii Masao's message of mar jul 17 13:58:38 -0400 2012:

> >> You're right. If the error is detected, that function always returns false
> >> and the error message is emitted (but I think that current error message
> >> "pg_basebackup: child process exited with error 1" is confusing....),
> >> so it's OK. But if walsender in the server is terminated by SIGTERM,
> >> no error is detected and pg_basebackup background process gets out
> >> of the loop in ReceiveXlogStream() and returns true.
> >
> > Oh. Because the server does a graceful shutdown. D'uh, of course.
> >
> > Then yes, your suggested fix seems like a good one.
> 
> Attached patch adds the fix.
> 
> Also I found I had forgotten to set the file descriptor to -1 at the end of
> ReceiveXlogStream(), in previously-committed my patch. Attached patch
> fixes this problem.

This hasn't been committed yet AFAICT, and it probably needs a refresh
now after my changes to pg_basebackup.  Please update the patch.  Also,
if this is not in the Open Items list, please put it there so that we
don't forget it before the 9.2 release.

-- 
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2012-07-31 16:23:40
Subject: Fixing syslogger rotation logic for first-time case
Previous:From: Alvaro HerreraDate: 2012-07-31 15:06:32
Subject: Re: several problems in pg_receivexlog

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group