| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Erwin Brandstetter <brandstetter(at)falter(dot)at>, pgadmin-hackers(at)postgresql(dot)org, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
| Subject: | Re: Changed default ordering in tables |
| Date: | 2011-08-06 12:49:42 |
| Message-ID: | 1312634982.2039.19.camel@laptop |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Fri, 2011-07-29 at 10:33 +0100, Dave Page wrote:
> On Fri, Jul 29, 2011 at 9:14 AM, Erwin Brandstetter
> <brandstetter(at)falter(dot)at> wrote:
> > So, that's two distinct issue:
> > - "Last 100 rows" broken for multi-column pkeys.
> > - Default sort order DESC for edit grid, where it should be ASC.
>
> That one I can reproduce, and fix. Patch attached.
>
> Ashesh, can you review and test please? We're getting close to release
> so I want to be extra careful.
>
I checked your patch. Seems good to me. So I applied it. I also applied
another patch to fix Erwin's bug (missing initialization of the
pkAscending variable).
--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2011-08-06 13:02:57 | Re: Changed default ordering in tables |
| Previous Message | Guillaume Lelarge | 2011-08-06 12:48:25 | pgAdmin III commit: Fix the ordering on View Data |