Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Adjust basebackup.c to suppress compiler warnings.

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Adjust basebackup.c to suppress compiler warnings.
Date: 2011-01-11 20:00:05
Message-ID: 1294775954-sup-6748@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-committers
> Magnus Hagander <magnus(at)hagander(dot)net> writes:

> > I noticed you didn't create a function prototype at the top of the
> > file for this function. Was that intentional, or missed? If it was
> > intentional, can you give me a quick lesson in when it should be done
> > and whe nit shouldn't? :-)

I think normally you can omit the prototype when the function definition
comes before its first usage.

-- 
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

pgsql-committers by date

Next:From: Magnus HaganderDate: 2011-01-11 20:12:34
Subject: pgsql: Add missing function prototype, for consistency
Previous:From: Tom LaneDate: 2011-01-11 19:44:04
Subject: Re: pgsql: Adjust basebackup.c to suppress compiler warnings.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group