> Magnus Hagander <magnus(at)hagander(dot)net> writes:

> > I noticed you didn't create a function prototype at the top of the
> > file for this function. Was that intentional, or missed? If it was
> > intentional, can you give me a quick lesson in when it should be done
> > and whe nit shouldn't? :-)

I think normally you can omit the prototype when the function definition
comes before its first usage.

-- 
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

• Re: pgsql: Adjust basebackup.c to suppress compiler warnings. at 2011-01-11 19:44:04 from Tom Lane

pgsql-committers by date

Next:	From: Magnus Hagander	Date: 2011-01-11 20:12:34
	Subject: pgsql: Add missing function prototype, for consistency
Previous:	From: Tom Lane	Date: 2011-01-11 19:44:04
	Subject: Re: pgsql: Adjust basebackup.c to suppress compiler warnings.