Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per
Date: 2010-04-06 13:15:53
Message-ID: 1270559753.24910.6089.camel@ebony
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, 2010-04-06 at 16:01 +0300, Heikki Linnakangas wrote:

> > Having the Startup process wait does not buy us anything at all.
> > Currently if the Startup process finishes more quickly than the
> > WALreceiver it will wait for 100ms.
>
> Ok, here's a patch to add signaling between walreceiver and startup
> process. It indeed isn't much code, and seems pretty safe, so if no-one
> objects strongly, I'll commit. It won't help on platforms where
> pg_usleep() isn't interrupted by signals, though, but we can live with that.

Looks good.

There is also the fixed 5 sec wait when polling the archive. I would
like to make that a parameter, since that was previously controllable
with pg_standby.

--
Simon Riggs www.2ndQuadrant.com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-04-06 14:11:08 Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per
Previous Message Heikki Linnakangas 2010-04-06 13:01:29 Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-04-06 13:57:37 Re: message clarifications
Previous Message Merlin Moncure 2010-04-06 13:07:06 Re: SELECT constant; takes 15x longer on 9.0?