Re: IntArray in c.h

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: IntArray in c.h
Date: 2010-01-01 19:54:16
Message-ID: 1262375656.29407.6.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On tor, 2009-12-31 at 11:28 -0500, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > The definition of c.h is bogus anyway. You might think it contains
> > includes and defines to set up a portable C environment, which is what
> > the first half indeed does.
>
> > But then things like regproc, transaction ID types, IntArray, varlena,
> > bytea, oidvector, NameData, etc. do not belong there and should be moved
> > to postgres.h.
>
> Actually, what c.h does is to provide definitions that are needed in
> both frontend and backend code. And we do NOT want to start including
> postgres.h in frontend code. It might be that some of the declarations
> there are useless to frontend code and could be moved, but trying to be
> as strict as you suggest is only going to create problems.

I think the list above is a pretty good list of things that client code
doesn't need, plus or minus a few things maybe.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2010-01-01 19:55:42 Re: win32 socket definition
Previous Message Magnus Hagander 2010-01-01 19:50:01 Re: Win64 warnings about size_t