Skip site navigation (1) Skip section navigation (2)

Re: operator exclusion constraints

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: operator exclusion constraints
Date: 2009-12-02 05:18:34
Message-ID: 1259731114.3355.126.camel@jdavis (view raw or flat)
Thread:
Lists: pgsql-hackers
On Tue, 2009-12-01 at 23:19 -0500, Robert Haas wrote:
> For parity with unique constraints, I think that the message:
> 
> operator exclusion constraint violation detected: %s
> 
> should be changed to:
> 
> conflicting key value violates operator exclusion constraint "%s"

Done, and updated tests.

> In ATAddOperatorExclusionConstraint, "streatagy" is misspelled.

Fixed.

> Other than that, it looks good to me.

Great, thanks for the detailed review!

Regards,
	Jeff Davis

Attachment: operator-exclusion-constraints-20091201.context.patch
Description: text/x-patch (102.2 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2009-12-02 05:24:04
Subject: Re: [PATCH] bugfix for int2vectorin
Previous:From: KaiGai KoheiDate: 2009-12-02 05:11:22
Subject: Re: SE-PgSQL patch review

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group