Skip site navigation (1) Skip section navigation (2)

Re: GIN needs tonic

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: GIN needs tonic
Date: 2009-09-15 19:28:14
Message-ID: 1253042894.27962.2.camel@ebony.2ndQuadrant (view raw or flat)
Thread:
Lists: pgsql-bugs
On Tue, 2009-09-15 at 14:31 -0400, Tom Lane wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> > On Tue, 2009-09-15 at 09:41 +0300, Heikki Linnakangas wrote:
> >> This means that the WAL replay of that record type has never been tested
> >> correctly :-(.
> 
> > This must have been added after mid-Feb this year. I notice there are a
> > few places where functionality is tested against temp tables, which may
> > mask other non-recoverable issues in this and other rmgrs. We should
> > make it standard practice to include only non-temp tables to cover
> > functionality other than specific temp table commands.
> 
> I've pointed out before that the regression tests are not particularly
> meant to provide an exhaustive test of WAL recovery.  In this particular
> case, so far as I can tell the bug is only observable with
> full_page_writes turned off --- otherwise XLogInsert will invariably
> decide to log the full page, because it's going to see a zeroed-out
> LSN in the passed-in buffer.  

Yes, I was testing with full_page_writes = off at that point.

-- 
 Simon Riggs           www.2ndQuadrant.com


In response to

Responses

pgsql-bugs by date

Next:From: Tom LaneDate: 2009-09-15 19:34:55
Subject: Re: GIN needs tonic
Previous:From: Joseph ShraibmanDate: 2009-09-15 19:26:51
Subject: BUG #5058: [jdbc] Silent failure with executeUpdate()

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group