Skip site navigation (1) Skip section navigation (2)

Re: pg_dump additional options for performance

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: pg_dump additional options for performance
Date: 2008-07-20 06:37:42
Message-ID: 1216535862.19656.845.camel@ebony.2ndQuadrant (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On Sun, 2008-07-20 at 05:47 +0100, Simon Riggs wrote:
> On Sat, 2008-07-19 at 23:07 -0400, Stephen Frost wrote:
> > Simon,
> > 
> >   I agree with adding these options in general, since I find myself
> >   frustrated by having to vi huge dumps to change simple schema things.
> >   A couple of comments on the patch though:
> > 
> >   - Conflicting option handling
> >     I think we are doing our users a disservice by putting it on them to
> > 	figure out exactly what:
> > 	multiple object groups cannot be used together
> > 	means to them.  You and I may understand what an "object group" is,
> > 	and why there can be only one, but it's a great deal less clear than
> > 	the prior message of
> > 	options -s/--schema-only and -a/--data-only cannot be used together
> > 	My suggestion would be to either list out the specific options which
> > 	can't be used together, as was done previously, or add a bit of (I
> > 	realize, boring) code and actually tell the user which of the
> > 	conflicting options were used.
> > 
> >   - Documentation
> > 	When writing the documentation I would stress that "pre-schema" and
> > 	"post-schema" be defined in terms of PostgreSQL objects and why they
> > 	are pre vs. post.
> > 
> >   - Technically, the patch needs to be updated slightly since another
> > 	pg_dump-related patch was committed recently which also added
> > 	options and thus causes a conflict.
> > 
> >   Beyond those minor points, the patch looks good to me.
> 
> Thanks for the review. I'll make the changes you suggest.

Patch updated to head, plus changes/docs requested.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support

Attachment: pg_dump_prepost.v3.patch
Description: text/x-patch (36.7 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Peter EisentrautDate: 2008-07-20 07:50:36
Subject: Re: Getting to universal binaries for Darwin
Previous:From: Bruce MomjianDate: 2008-07-20 06:08:57
Subject: Re: .psqlrc output for \pset commands

pgsql-patches by date

Next:From: Tatsuo IshiiDate: 2008-07-20 15:42:16
Subject: Re: [PATCHES] WITH RECUSIVE patches 0717
Previous:From: Simon RiggsDate: 2008-07-20 04:47:09
Subject: Re: pg_dump additional options for performance

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group