Skip site navigation (1) Skip section navigation (2)

Re: patch fixing the old RETURN NEXT bug

From: Neil Conway <neilc(at)samurai(dot)com>
To: "Sergey E(dot) Koposov" <math(at)sai(dot)msu(dot)ru>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: patch fixing the old RETURN NEXT bug
Date: 2006-02-19 23:59:44
Message-ID: 1140393584.2615.13.camel@localhost.localdomain (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On Sun, 2006-02-12 at 20:15 +0300, Sergey E. Koposov wrote:
> I'm proposing the fix of this bug:
> http://archives.postgresql.org/pgsql-hackers/2005-02/msg00498.php

I think the suggested logic for compatible_tupdesc() is still wrong. For
example, the patch rejects the following:

create table usno (ra real, dec real, bmag real, rmag real, ipix int8);
create function ret_next_check() returns setof usno as $$
declare
    r record;
begin
    for r in select * from usno loop
        return next r;
    end loop;
    return;
end;
$$ language plpgsql;

insert into usno values (1.0, 2.0, 3.0, 4.0, 5);
select * from ret_next_check();
alter table usno drop column ipix;
select * from ret_next_check(); -- fails, should succeed

Also, this patch should include updates to the regression tests.

-Neil



In response to

Responses

pgsql-hackers by date

Next:From: eleinDate: 2006-02-20 00:04:44
Subject: Re: Domains and supporting functions
Previous:From: Satoshi NagayasuDate: 2006-02-19 23:49:43
Subject: Re: Prepared Xacts and Vacuum question

pgsql-patches by date

Next:From: James William PyeDate: 2006-02-20 00:47:42
Subject: ScanDirections
Previous:From: Steve AtkinsDate: 2006-02-19 22:14:47
Subject: Re: pg_service.conf

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group