Skip site navigation (1) Skip section navigation (2)

Re: Multiple -t options for pg_dump

From: Neil Conway <neilc(at)samurai(dot)com>
To: David Fetter <david(at)fetter(dot)org>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Multiple -t options for pg_dump
Date: 2005-09-20 18:49:26
Message-ID: 1127242166.17597.17.camel@localhost.localdomain (view raw or flat)
Thread:
Lists: pgsql-patches
On Tue, 2005-20-09 at 11:33 -0700, David Fetter wrote:
> I am hoping to make a case for inclusion in 8.1.  The code is
> completely isolated in one command and does not affect anyone who
> does not use the new features.

On those grounds we could include a lot of new features during the 8.1
beta period. IMHO it is too late for new features at this point in the
release cycle.

> > AFAICS the goto is unnecessary -- just break out of the loop when you
> > find a match, and test i == ntups outside the loop.
> 
> I tried that.  How do I break out of both loops without a goto?

Oh, yeah, I guess you need a goto, but you can at least avoid rechecking
the loop condition:

for (;;)
{
    for (;;)
    {
        if (match_found)
            goto done;
    }
}

/* If we got here, no match */
error();

done: /* Otherwise we're good */

-Neil



In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-09-20 19:00:56
Subject: Re: [PORTS] Solaris - psql returns 0 instead of 1 for file not found.
Previous:From: David FetterDate: 2005-09-20 18:33:39
Subject: Re: Multiple -t options for pg_dump

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group