Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Fix compiling errors on Windows platform. Fix wrong usage of

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tatsuo Ishii <ishii(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix compiling errors on Windows platform. Fix wrong usage of
Date: 2012-10-07 14:57:18
Message-ID: 11079.1349621838@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Are you sure this is going to fix the Windows issues?

Well, it will fix the 'LOBLKSIZELL' business anyway --- that's coming
from trying to use INT64CONST() on something that's not, um, a constant.

More generally, though, it's glaringly obvious that this patch was never
tested on a 32-bit build.  Somebody had better do that.

			regards, tom lane


In response to

Responses

pgsql-committers by date

Next:From: Andrew DunstanDate: 2012-10-07 21:32:01
Subject: pgsql: Quiet a few MSC compiler warnings.
Previous:From: Andrew DunstanDate: 2012-10-07 14:53:00
Subject: Re: pgsql: Fix compiling errors on Windows platform. Fix wrong usage of

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group