Re: Domain casting still not working right?

From: Rod Taylor <rbt(at)rbt(dot)ca>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Domain casting still not working right?
Date: 2003-05-24 17:38:00
Message-ID: 1053797879.279.123.camel@jester
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

It's because of the coerce_to_target_type string hack:

/*
* String hacks to get transparent conversions for char and varchar:
* if a coercion to text is available, use it for forced coercions to
* char(n) or varchar(n).
*
* This is pretty grotty, but seems easier to maintain than providing
* entries in pg_cast that parallel all the ones for text.
*/

This hack works on the provided target type and not on the base target
type. Attached is a patch to goto the base type for this hack (fix the
if)

On Fri, 2003-05-23 at 18:35, Peter Eisentraut wrote:
> This particular case arose during work on the information schema:
>
> -- good
>
> select cast(55::oid AS varchar);
> varchar
> ---------
> 55
> (1 row)
>
> -- bad
>
> create domain test as varchar;
> CREATE DOMAIN
> select cast(55::oid AS test);
> ERROR: Cannot cast type oid to test
--
Rod Taylor <rbt(at)rbt(dot)ca>

PGP Key: http://www.rbt.ca/rbtpub.asc

Attachment Content-Type Size
domaincoercefix.patch text/x-patch 1.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2003-05-24 19:02:55 Re: Roadmap for FE/BE protocol redesign
Previous Message Bruce Momjian 2003-05-24 17:37:14 Re: XML ouput for psql

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2003-05-24 21:41:31 Re: Domain casting still not working right?
Previous Message Bruce Momjian 2003-05-24 17:37:14 Re: XML ouput for psql