Re: [HACKERS] Proposed GUC Variable

From: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
To: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Proposed GUC Variable
Date: 2002-08-29 16:09:58
Message-ID: 1030637398.3216.94.camel@camel
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

One of my users is generating a notice message --> NOTICE: Adding
missing FROM-clause entry for table "msg202" It might be helpful to
dump out the query on notice messages like this, and it looks like a
simple change as far as elog.c and guc.c are concerned, but would this
be overkill?

Robert Treat

On Wed, 2002-08-28 at 02:26, Gavin Sherry wrote:
> On Wed, 28 Aug 2002, Gavin Sherry wrote:
>
> > On Tue, 27 Aug 2002, Tom Lane wrote:
> >
> > > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > > But we should have some default to print some of the query,
> > >
> > > Why? So far you've been told by two different people (make that three
> > > now) that such a behavior is useless, and no one's weighed in in its
> > > favor ...
> >
> > I completely agree. Nothing wrong with adding another guc variable and
> > since it is a debug variable people expect lots of verbosity.
>
> Attached is the patch. debug_print_error_query is set to false by default.
>
> For want of a better phrase, I've prepended 'original query: ' to the
> error message to highlight why it is in the log.
>
> Gavin
>
> ----
>

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas F. O'Connell 2002-08-29 16:13:03 the optimizer and exists
Previous Message Bruce Momjian 2002-08-29 15:16:20 Re: [SQL] LIMIT 1 FOR UPDATE or FOR UPDATE LIMIT 1?

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-08-29 16:11:19 Re: Visibility regression test
Previous Message Tom Lane 2002-08-29 16:02:59 Re: Proposed patch for qual pushdown into UNION/INTERSECT