Some architectures need "signed char" declarations

From: Oliver Elphick <olly(at)lfix(dot)co(dot)uk>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Some architectures need "signed char" declarations
Date: 2002-01-09 11:43:04
Message-ID: 1010576586.32569.3.camel@linda
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I recently got a Debian bug report about 3 architectures where char is
unsigned by default. There were 2 locations identified in the code
where a char is compared with a negative value, and should therefore be
declared as a "signed char". There may be others in 7.2, but I don't
myself have access to a suitable machine for testing.

The locations I am aware of are:

src/backend/libpq/hba.c GetCharSetByHost(): if (c == EOF)
src/backend/utils/init/miscinit.c SetCharSet(): if (c == EOF)

The architectures are Linux on: arm, powerpc and s390.

--
Oliver Elphick Oliver(dot)Elphick(at)lfix(dot)co(dot)uk
Isle of Wight http://www.lfix.co.uk/oliver
GPG: 1024D/3E1D0C1C: CA12 09E0 E8D5 8870 5839 932A 614D 4C34 3E1D 0C1C

"And not only so, but we glory in tribulations also;
knowing that tribulation worketh patience; And
patience, experience; and experience, hope; And hope
maketh not ashamed; because the love of God is shed
abroad in our hearts by the Holy Ghost which is given
unto us." Romans 5:3-5

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zeugswetter Andreas SB SD 2002-01-09 11:58:36 --with-tcl build on AIX (and others) fails
Previous Message Oleg Bartunov 2002-01-09 10:52:54 Re: RC1 time?