Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] YADP - Yet another Dependency Patch

From: "Rod Taylor" <rbt(at)zort(dot)ca>
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] YADP - Yet another Dependency Patch
Date: 2002-04-16 11:32:12
Message-ID: 0b5501c1e53a$5a47e6d0$8001a8c0@jester (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Yes, I've removed all of those.

I've submitted a list of stuff it tracked earlier, but will do so
again with the next patch.  Basically, anything simple and
straightforward ;)

It doesn't manage dependencies of function code, view internals,
default internals as I don't know how to find navigate an arbitrary
parse tree for that information.  Some function code isn't even
available (C), so its next to impossible.

No, it doesn't directly tick off any todo item other than the first in
dependency.  Make pg_depend table ;)

--
Rod Taylor

Your eyes are weary from staring at the CRT. You feel sleepy. Notice
how restful it is to watch the cursor blink. Close your eyes. The
opinions stated above are yours. You cannot imagine why you ever felt
otherwise.

----- Original Message -----
From: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Rod Taylor" <rbt(at)zort(dot)ca>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>; <pgsql-patches(at)postgresql(dot)org>;
"Hackers List" <pgsql-hackers(at)postgresql(dot)org>
Sent: Tuesday, April 16, 2002 1:15 AM
Subject: Re: [HACKERS] [PATCHES] YADP - Yet another Dependency Patch


> Rod Taylor wrote:
> > [ copied to hackers ]
> >
> > > 1. I don't like the code that installs and removes ad-hoc
> > dependencies
> > > from relations to type Oid.  On its own terms it's wrong (if it
were
>
> Looks good to me.  I realize this is a huge chunk of code.  The only
> ultra-minor thing I saw was the use of dashes for comment blocks
when
> not needed:
>
> /*  ----
> *  word
> *  ----
> */
>
> We use dashes like this only for comments that shouldn't be
reformatted
> by pgindent.
>
> The one thing I would like to know is what things does it track, and
> what does it not track?  Does it complete any TODO items, or do we
save
> that for later?
>
> --
>   Bruce Momjian                        |  http://candle.pha.pa.us
>   pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
>   +  If your life is a hard drive,     |  830 Blythe Avenue
>   +  Christ can be your backup.        |  Drexel Hill, Pennsylvania
19026
>


In response to

Responses

pgsql-hackers by date

Next:From: Mario WeilguniDate: 2002-04-16 11:49:40
Subject: Improved vacuumlo
Previous:From: Denis PerchineDate: 2002-04-16 11:14:17
Subject: Re: Firebird 1.0 released

pgsql-patches by date

Next:From: Mario WeilguniDate: 2002-04-16 11:57:53
Subject: Improved vacuumlo command
Previous:From: Jochem van DietenDate: 2002-04-16 10:19:12
Subject: Re: Alter/update large tables - VERRRY annoying behaviour!

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group