RE: Re: LIKE gripes

From: "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp>
To: "Thomas Lockhart" <lockhart(at)alumni(dot)caltech(dot)edu>
Cc: <pgsql-hackers(at)postgreSQL(dot)org>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: RE: Re: LIKE gripes
Date: 2000-08-08 07:40:28
Message-ID: 000b01c0010b$ec4b4dc0$2801007e@tpf.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Where has MULTIBYTE Stuff in like.c gone ?

Hiroshi Inoue

> -----Original Message-----
> From: Thomas Lockhart
> Sent: Monday, August 07, 2000 10:07 AM
> To: Tom Lane
> Cc: pgsql-hackers(at)postgreSQL(dot)org
> Subject: [HACKERS] Re: LIKE gripes
>
>
> > 1. like.c doesn't compile cleanly anymore:
> > $ make
> > gcc -c -I../../../../src/include -O1 -Wall
> -Wmissing-prototypes -Wmissing-declarations -g -o like.o like.c
> > like.c:143: warning: no previous prototype for `inamelike'
> > like.c:155: warning: no previous prototype for `inamenlike'
> > like.c:167: warning: no previous prototype for `inamelike_escape'
> > like.c:180: warning: no previous prototype for `inamenlike_escape'
> > like.c:193: warning: no previous prototype for `itextlike'
> > like.c:205: warning: no previous prototype for `itextnlike'
> > like.c:217: warning: no previous prototype for `itextlike_escape'
> > like.c:230: warning: no previous prototype for `itextnlike_escape'
> > like.c: In function `MatchTextLower':
> > like.c:401: warning: implicit declaration of function `tolower'
>
> OK, will look at it. The first ones I see here; the second I'm not sure
> I do. Will see what other files have for #include's.
>
> > 2. The strings regress test fails. I think you forgot to commit the
> > expected file to go with the new test file?
>
> Yup. I just noticed that here after updating the tree.
>
> - Thomas
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kovacs Zoltan Sandor 2000-08-08 07:47:46 ACL inheritance for sequences
Previous Message Zeugswetter Andreas SB 2000-08-08 07:39:55 AW: UNIONS