Re: BUG #16108: Colorization to the output of command-line has unproperly behaviors at Windows platform

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: PG Bug reporting form <noreply(at)postgresql(dot)org>
Cc: PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, tanghy(dot)fnst(at)cn(dot)fujitsu(dot)com
Subject: Re: BUG #16108: Colorization to the output of command-line has unproperly behaviors at Windows platform
Date: 2019-11-12 08:39:17
Message-ID: CA+hUKG+Em5CO27qk4PC9syK+p2n0a0ULP_Vm3OqpvdXGQTn0=A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Tue, Nov 12, 2019 at 9:30 PM PG Bug reporting form
<noreply(at)postgresql(dot)org> wrote:
> The following bug has been logged on the website:
>
> Bug reference: 16108
> Logged by: Haiying Tang
> Email address: tanghy(dot)fnst(at)cn(dot)fujitsu(dot)com
> PostgreSQL version: 12.0
> Operating system: Windows
> Description:
>
> Hello
>
> I found the following release notes in PG12 is not working properly at
> Windows.
> > •Add colorization to the output of command-line utilities
>
> Following the release note, I've set the the environment variable PG_COLOR
> to auto, then I run pg_dump command with an incorrect passwd.
> However, the command-line output is not colorized as the release notes
> said.
>
> Before PG_COLOR=auto is set: pg_dump: error: connection to database
> "tanghy.fnst" failed: FATAL:
> After PG_COLOR=auto is set: [01mpg_dump: [0m [01;31merror: [0mconnection
> to database "tanghy.fnst" failed: FATAL
>
> I think the colorization to the output of command-line is not supported at
> Windows.
> Maybe function "pg_logging_init" at source "src\common\logging.c" should add
> a platform check.
> Besides, the related release note of PG12 should add some description about
> it.

Based on this:

https://en.wikipedia.org/wiki/ANSI_escape_code#DOS_and_Windows

... I wonder if it works if you use the new Windows Terminal, and I
wonder if it would work on the older thing if we used the
SetConsoleMode() flag it mentions.

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Arseny Sher 2019-11-12 11:35:10 Re: ERROR: subtransaction logged without previous top-level txn record
Previous Message PG Bug reporting form 2019-11-12 08:29:10 BUG #16108: Colorization to the output of command-line has unproperly behaviors at Windows platform

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-11-12 08:46:49 Re: [BUG FIX] Uninitialized var fargtypes used.
Previous Message PG Bug reporting form 2019-11-12 08:29:10 BUG #16108: Colorization to the output of command-line has unproperly behaviors at Windows platform