Re: BUG #15932: Module passwordcheck doesn't reference previous hooks

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: rafaelthca(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15932: Module passwordcheck doesn't reference previous hooks
Date: 2019-07-31 07:54:17
Message-ID: B8D6D6DC-484B-4D14-9CAD-F08B486E0B8B@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

> On 31 Jul 2019, at 09:34, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Jul 31, 2019 at 09:23:54AM +0200, Daniel Gustafsson wrote:
>> LGTM. A small nitpick is that the below comment isn’t really giving the full
>> picture, prev_check_password_hook is not just used for unload but for the hook
>> chaining.
>
> My understanding is that it's the same meaning, and also:
> $ git grep "in case of unload"
> contrib/auto_explain/auto_explain.c:/* Saved hook values in case of
> unload */
> contrib/pg_stat_statements/pg_stat_statements.c:/* Saved hook values
> in case of unload */
> src/test/modules/test_rls_hooks/test_rls_hooks.c:/* Saved hook values
> in case of unload */

Hmm, ok, IMO my comment applies to those as well, but it may very well be me
just reading it wrong. Either way, +1 for pushing your patch.

cheers ./daniel

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Marks Polakovs 2019-07-31 08:55:14 UPDATE with json_populate_recordset empty array crashes server
Previous Message Michael Paquier 2019-07-31 07:34:01 Re: BUG #15932: Module passwordcheck doesn't reference previous hooks