Re: BUG #15910: Valgrind-detected error in DecodeTimeOnly

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15910: Valgrind-detected error in DecodeTimeOnly
Date: 2019-08-06 06:21:11
Message-ID: 20190806062111.GG32256@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Mon, Aug 05, 2019 at 08:55:55AM +0300, Alexander Lakhin wrote:
> In case this bug is worth fixing, please look at the improved patch with
> the corresponding regression test.

In this case, DecodeSpecial() decodes the abbrevation passed down as
UNITS, which is right on its own. Still, afterwards the code fails to
correctly set a date from the string present. In short, your
suggestion of fix looks good to me and that's more consistent with the
full timezone spec case. The test case you added in this patch
triggers the error in the code path where the timezone is not
specified. Could you add an extra test case for the timezone
abbreviation?

Note that the next set of minor versions is very close by (we are in a
cease-fire period for commits on back-branches), so this won't be
fixed in the upcoming releases.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2019-08-06 06:24:05 Re: BUG #15910: Valgrind-detected error in DecodeTimeOnly
Previous Message PG Bug reporting form 2019-08-05 08:15:57 BUG #15939: Postgres database size is growing due to oraphan objects